Project

General

Profile

Actions

Bug #10444

closed

linenoise: this statement may fall through

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2019-02-23
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

With warnings enabled, we get this error:

    ../../common/linenoise/linenoise.c:652:13: error: this statement may fall through [-Werror=implicit-fallthrough=]
                 refreshLine(&l);
                 ^~~~~~~~~~~~~~~
    ../../common/linenoise/linenoise.c:653:9: note: here
             case BACKSPACE:   /* backspace */
             ^~~~

Actions #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit c4b91d4b4753f33280a63b16f5116d23427088b1

commit  c4b91d4b4753f33280a63b16f5116d23427088b1
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-25T19:48:04.000Z

    10444 linenoise: this statement may fall through
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF