Project

General

Profile

Bug #10450

mDNS binaries should be reproducible

Added by Joshua Clulow 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2019-02-25
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

The usr/bin/dns-sd binary built from the gate includes a build timestamp, which is generally not helpful:

root@jenkins-oi0:~# strings /export/jenkins/workspace/wsdiff/current/proto/root_i386/usr/bin/dns-sd | grep Feb
@(#) dns-sd mDNSResponderVersion (Feb 25 2019 01:18:22)

This causes it to show up in wsdiff output even when there are no other changes:

usr/bin/dns-sd
NOTE: ELF .rodata difference detected.

1096,1099c1096,1099
< 0022440       (   F   e   b       2   5       2   0   1   9       0   0
<         65462820 35322062 31303220 30302039
< 0022460   :   0   2   :   4   4   )  \0  \t   T   e   s   t       D   a
<         3a32303a 00293434 73655409 61442074
---
> 0022440       (   F   e   b       2   5       2   0   1   9       0   1
>         65462820 35322062 31303220 31302039
> 0022460   :   1   8   :   2   2   )  \0  \t   T   e   s   t       D   a
>         3a38313a 00293232 73655409 61442074

History

#1

Updated by Toomas Soome 5 months ago

  • Status changed from New to In Progress
  • Assignee set to Toomas Soome
  • % Done changed from 0 to 90

Testing Notes

tsoome@beastie:/code/illumos-gate$ strings usr/src/cmd/cmd-inet/usr.lib/mdnsd/mdnsd | grep "@(#)" 
@(#) mDNSResponder-878.1.1
tsoome@beastie:/code/illumos-gate$ strings usr/src/lib/libdns_sd/amd64/libdns_sd.so.1 | grep "@(#)" 
@(#) libdns_sd 878.1.1
tsoome@beastie:/code/illumos-gate$ strings usr/src/cmd/cmd-inet/usr.bin/dns-sd/dns-sd | grep "@(#)" 
@(#) dns-sd 878.1.1
tsoome@beastie:/code/illumos-gate$
#2

Updated by Electric Monk 5 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 67ad1fc626a04c21a1ef53202c9fc7a77829681e

commit  67ad1fc626a04c21a1ef53202c9fc7a77829681e
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-27T08:30:43.000Z

    10450 mDNS binaries should be reproducible
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Joshua M. Clulow <josh@sysmgr.org>

Also available in: Atom PDF