Limit number of multicast NCEs
We need to limit the number of multicast NCEs that get created.
Updated by Joshua Clulow 17 days ago
Testing Notes (from Dan)¶
The fix, which limits the number of multicast NCEs (currently 16384), has been tested in DEBUG and non-DEBUG kernels while running a multicast spraying program that iterates rapidly over a /12 (1M, aka. 1024^2) multicast space sending datagrams. Additional tests have included rebooting a zone mid-spray, or unplumbing a NIC (i.e. ill deletion) during the spray. A DEBUG kernel shows no TCP/IP memory leaks, but ill reference-tracing does not have a _notr version (different threads holding and releasing violates DEBUG reference tracing assumptions) so this fix inlines ill_ref* without DEBUG reference tracing.
An additional test suggests that a global zone with many NCEs may be able to reboot(1M) without a delay, so this bug affects interface down time or exclusive-stack zone halt time.
Additional testing reconfirms all-nodes mcast for both IPv6 (ff02::1, solicited-node for unicast ND) and IPv4 (220.127.116.11) do not break.
Updated by Electric Monk 17 days ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit 42c5ef032d8316897a2ba9f9ebf4b9c2654ec345 Author: Dan McDonald <firstname.lastname@example.org> Date: 2019-03-02T21:02:09.000Z 10472 Limit number of multicast NCEs Reviewed by: Cody Peter Mello <email@example.com> Reviewed by: Jason King <firstname.lastname@example.org> Reviewed by: Robert Mustacchi <email@example.com> Reviewed by: Richard Lowe <firstname.lastname@example.org> Approved by: Joshua M. Clulow <email@example.com>