Project

General

Profile

Bug #10481

loader.efi: comconsole needs to identify the port handle better

Added by Toomas Soome 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2019-03-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

The UEFI has function to fetch the list of handles of particular type, LocateHandle(), unfortunately the ordering of the result is not defined. In case of serial ports, however, we would need to create the meaningful relation between device name and handle, as we do use names determining the port: ttya, ttyb etc.

There are actual cases where the handle array order is unexpected, it may be that the default console device is set as first handle (ttyb versus ttya), or some other order for handles is set.

We can query device path for a handle, and from that device path we can identify the port. This issue is attempting just that.

Also, currently we only deal with "onboard" serial ports, usb ports are not addressed.

History

#1

Updated by Electric Monk 9 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit a2f10c447c8cfe20ac08f6c287fe67307f2a5175

commit  a2f10c447c8cfe20ac08f6c287fe67307f2a5175
Author: Toomas Soome <tsoome@me.com>
Date:   2019-03-21T15:43:45.000Z

    10481 loader.efi: comconsole needs to identify the port handle better
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF