Project

General

Profile

Actions

Bug #10524

closed

wsdiff much slower after move from deprecated commands module

Added by Andy Fiddaman over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
tools - gate/build tools
Start date:
2019-03-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

wsdiff was modified under #9979 so that it could be run under wither Python2 or Python3. Part of this work was to replace code that used the deprecated commands module with the newer subprocess module. This change has inadvertently caused a performance regression.

Here are some timings for running wsdiff against usr/bin with both python2 and python3:

python2 =wsdiff proto/root_i386{,-nd}/usr/bin  467.68s user 238.26s system 281% cpu 4:10.37 total
python2 =wsdiff proto/root_i386{,-nd}/usr/bin  463.40s user 236.09s system 280% cpu 4:09.71 total
python3 =wsdiff proto/root_i386{,-nd}/usr/bin  27.50s user 129.93s system 109% cpu 2:23.35 total
python3 =wsdiff proto/root_i386{,-nd}/usr/bin  27.73s user 129.84s system 110% cpu 2:22.86 total

And with python2 using the version before #9979

wsdiff proto/root_i386{,-nd}/usr/bin  11.84s user 11.74s system 69% cpu 33.974 total

Related issues

Related to illumos gate - Feature #9979: Support python3 for in-gate toolsClosedAndy Fiddaman2019-02-06

Actions
Actions

Also available in: Atom PDF