Project

General

Profile

Bug #10538

sppp: cast between incompatible function types

Added by Toomas Soome 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-03-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Build error with gcc 8:

../../common/io/ppp/sppp/sppp_mod.c:96:2: error: cast between incompatible function types from 'void (*)(queue_t *, mblk_t *)' {aka 'void (*)(struct queue *, struct msgb *)'} to 'int (*)()' [-Werror=cast-function-type]
  (int (*)())sppp_uwput, /* qi_putp */
  ^
../../common/io/ppp/sppp/sppp_mod.c:97:2: error: cast between incompatible function types from 'void (*)(queue_t *)' {aka 'void (*)(struct queue *)'} to 'int (*)()' [-Werror=cast-function-type]
  (int (*)())sppp_uwsrv, /* qi_srvp */
  ^
../../common/io/ppp/sppp/sppp_mod.c:106:2: error: cast between incompatible function types from 'void (*)(queue_t *, mblk_t *)' {aka 'void (*)(struct queue *, struct msgb *)'} to 'int (*)()' [-Werror=cast-function-type]
  (int (*)())sppp_lrput, /* qi_putp */
  ^
../../common/io/ppp/sppp/sppp_mod.c:107:2: error: cast between incompatible function types from 'void (*)(queue_t *)' {aka 'void (*)(struct queue *)'} to 'int (*)()' [-Werror=cast-function-type]
  (int (*)())sppp_lrsrv, /* qi_srvp */
  ^
../../common/io/ppp/sppp/sppp_mod.c:117:2: error: cast between incompatible function types from 'void (*)(queue_t *)' {aka 'void (*)(struct queue *)'} to 'int (*)()' [-Werror=cast-function-type]
  (int (*)())sppp_lwsrv, /* qi_srvp */
  ^
cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk about 2 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 2bcc9601e83363d9147978a7616864c880b5c05a

commit  2bcc9601e83363d9147978a7616864c880b5c05a
Author: Toomas Soome <tsoome@me.com>
Date:   2019-03-21T16:32:41.000Z

    10538 sppp: cast between incompatible function types
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF