Project

General

Profile

Actions
Copy link

Bug #10547

open

SMB cstyle cleanup

Added by Joshua M. Clulow about 3 years ago. Updated about 3 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
cifs - CIFS server and client
Start date:
2019-03-13
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

There are rather a lot of existing cstyle issues in the SMB code; e.g., at least within:

  • common/smbclnt
  • lib/libsmbfs
  • lib/smbclnt
  • lib/smbsrv
  • uts/common/fs/smbclnt
  • uts/common/fs/smbsrv

This code is quite modern and is actively maintained. Cleaning up the violations will make it much easier to avoid introducing new ones in the future. The violations are substantially whitespace-related, so it should be possible to clean up with no substantive change in the program text.

While cleaning up the style issues we should also make sure the code is smatch clean.

Actions
Copy link
 #1

Updated by Gordon Ross about 3 years ago

Some requests for whoever might take on this task:

  1. Please separate your SMB client and SMB server changes. (This issue is mostly about the SMB client, though there's some code in common between the two.)
  2. It's a LOT easier on us (the "down stream") when any cstyle cleanup (etc) can be done in a way that's mostly "diff -w" invariant.
  3. There IS an "up stream" for the SMB client code, which is Apple's SMB client. However, their code has diverged far enough from ours that we really only cherry-pick functions etc. from theirs. So, in code that comes from them, (there's an Apple copyright) please try to keep a "light touch" re. formatting etc.
Actions
Copy link

Also available in: Atom PDF