Project

General

Profile

Actions

Bug #10575

closed

tem: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-03-20
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build error with NULL pointer:

In file included from ../../common/sys/param.h:48:0,
                 from ../../common/sys/t_lock.h:38,
                 from ../../common/sys/file.h:35,
                 from ../../common/io/tem.c:64:
../../common/io/tem.c: In function 'tems_failed':
../../common/sys/null.h:32:14: error: passing argument 2 of 'ldi_close' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/tem.c:379:32: note: in expansion of macro 'NULL'
  (void) ldi_close(tems.ts_hdl, NULL, credp);
                                ^~~~
In file included from ../../common/sys/ddi_obsolete.h:18:0,
                 from ../../intel/sys/ddi_isa.h:33,
                 from ../../common/sys/ddi_impldefs.h:46,
                 from ../../common/sys/sunddi.h:43,
                 from ../../common/io/tem.c:85:
../../common/sys/sunldi.h:105:12: note: expected 'int' but argument is of type 'void *'
 extern int ldi_close(ldi_handle_t, int flag, cred_t *);
            ^~~~~~~~~
cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 6efbc8a970529717f3354109b91e2916527c0286

commit  6efbc8a970529717f3354109b91e2916527c0286
Author: Toomas Soome <tsoome@me.com>
Date:   2019-03-22T18:20:05.000Z

    10575 tem: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF