Project

General

Profile

Actions

Bug #10579

closed

Don't allow dnode allocation if dn_holds != 0

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
2019-03-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The fix from ZoL:

    This patch simply fixes a small bug where dnode_hold_impl() could
    attempt to allocate a dnode that was in the process of being freed,
    but which still had active references. This patch simply adds the
    required check.

    Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Signed-off-by: Tom Caputi <tcaputi@datto.com>
    Closes #8249


Related issues

Related to illumos gate - Bug #10572: Fix race in dnode_check_slots_free()ClosedToomas Soome2019-03-20

Actions
Actions #1

Updated by Dan McDonald about 3 years ago

  • Related to Bug #10572: Fix race in dnode_check_slots_free() added
Actions #3

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit aa02ea01948372a32cbf08bfc31c72c32e3fc81e

commit  aa02ea01948372a32cbf08bfc31c72c32e3fc81e
Author: Tom Caputi <tcaputi@datto.com>
Date:   2019-03-27T13:27:22.000Z

    10572 Fix race in dnode_check_slots_free()
    10579 Don't allow dnode allocation if dn_holds != 0
    Reviewed by: Kody Kantor <kody.kantor@joyent.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF