Project

General

Profile

Actions

Bug #10580

closed

pnglite: unchecked function return

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2019-03-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

smatch check:

    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: /code/illumos-gate/usr/src/common/pnglite/pnglite.c:107 png_read_ihdr() error: unchecked function return 'file_read_ul'
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: /code/illumos-gate/usr/src/common/pnglite/pnglite.c:115 png_read_ihdr() error: unchecked function return 'file_read_ul'
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: /code/illumos-gate/usr/src/common/pnglite/pnglite.c:222 png_open() error: unchecked function return 'close'
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: /code/illumos-gate/usr/src/common/pnglite/pnglite.c:233 png_close() error: unchecked function return 'close'
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: /code/illumos-gate/usr/src/common/pnglite/pnglite.c:331 png_read_idat() error: unchecked function return 'file_read_ul'
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: /code/illumos-gate/usr/src/common/pnglite/pnglite.c:346 png_process_chunk() error: unchecked function return 'file_read_ul'
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: /code/illumos-gate/usr/src/common/pnglite/pnglite.c:375 png_process_chunk() error: unchecked function return 'file_read'
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: /code/illumos-gate/usr/src/common/pnglite/pnglite.c:573 png_get_data() error: unchecked function return 'png_end_inflate'

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit f7e4f33f27df122daef98e5b4b537dc159597da5

commit  f7e4f33f27df122daef98e5b4b537dc159597da5
Author: Toomas Soome <tsoome@me.com>
Date:   2019-03-26T18:24:53.000Z

    10580 pnglite: unchecked function return
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Rob Johnston <rob.johnston@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF