Feature #1060
termios missing cfmakeraw
90%
Description
The illumos termios implementation is missing cfmakeraw which is provided on Linux, Mac OSX and the BSD's. I decided to come up with a patch (see attached) that implements it because I think it's cleaner than pasting it into the source of things that want it.
Files
Related issues
Updated by Albert Lee over 9 years ago
Are the struct termios
members supposed to be private (i.e. implementation specific)? If so, by all means add this if it's the only way to set the flags without poking the structure.
Updated by Albert Lee over 9 years ago
Nope, http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/termios.h.html says the struct members are public. An extension to the public API when there is a trivial workaround would be against API conservatism, but since the extension is supported almost everywhere else...
Updated by Andrew Stormont over 9 years ago
The members of struct termios are not supposed to be private (afaik) but the steps required to put a termios into raw mode vary across platforms, which is the reason it was created.
Updated by Andrew Stormont over 9 years ago
- File cfmakeraw.diff cfmakeraw.diff added
Attached in an updated patch that alters grub to use cfmakeraw.
Updated by Andrew Stormont over 9 years ago
- File cfmakeraw.diff cfmakeraw.diff added
Oops. Last patch was missing cfmakeraw.c.
Updated by Andrew Stormont over 9 years ago
- File cfmakeraw.diff cfmakeraw.diff added
- Status changed from New to Feedback
- Assignee set to Andrew Stormont
Heres an updated patch which I think may be ready to submit. It's also worth noting that APT requires cfmakeraw.
Updated by Andrew Stormont over 7 years ago
- % Done changed from 0 to 90
Updated by Yuri Pankov over 7 years ago
- Status changed from Feedback to In Progress
- Tags deleted (
needs-triage)
Updated by Joshua M. Clulow 10 months ago
- Related to Bug #12470: raw mode should default to minimum reads of just one byte added