Project

General

Profile

Actions
Copy link

Feature #1060

open

termios needs cfmakeraw and cfsetspeed

Added by Andrew Stormont almost 11 years ago. Updated 6 months ago.

Status:
In Progress
Priority:
Low
Assignee:
Joshua M. Clulow
Category:
-
Start date:
2011-05-23
Due date:
% Done:

90%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
1808

Description

The illumos termios implementation is missing cfmakeraw which is provided on Linux, Mac OSX and the BSD's. I decided to come up with a patch (see attached) that implements it because I think it's cleaner than pasting it into the source of things that want it.

Files

Download all files
cfmakeraw.diff (5.54 KB) cfmakeraw.diff Andrew Stormont, 2011-05-23 12:13 PM
cfmakeraw.diff (4.61 KB) cfmakeraw.diff Andrew Stormont, 2011-06-08 10:38 AM
cfmakeraw.diff (6.16 KB) cfmakeraw.diff Andrew Stormont, 2011-06-08 08:28 PM
cfmakeraw.diff (5.04 KB) cfmakeraw.diff Andrew Stormont, 2011-06-29 03:33 PM

Related issues

Related to illumos gate - Bug #12470: raw mode should default to minimum reads of just one byteNew

Actions
Actions
Copy link
 #1

Updated by Albert Lee almost 11 years ago

Are the struct termios members supposed to be private (i.e. implementation specific)? If so, by all means add this if it's the only way to set the flags without poking the structure.

Actions
Copy link
 #2

Updated by Albert Lee almost 11 years ago

Nope, http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/termios.h.html says the struct members are public. An extension to the public API when there is a trivial workaround would be against API conservatism, but since the extension is supported almost everywhere else...

Actions
Copy link
 #3

Updated by Andrew Stormont almost 11 years ago

The members of struct termios are not supposed to be private (afaik) but the steps required to put a termios into raw mode vary across platforms, which is the reason it was created.

Actions
Copy link
 #4

Updated by Andrew Stormont almost 11 years ago

Attached in an updated patch that alters grub to use cfmakeraw.

Actions
Copy link
 #5

Updated by Andrew Stormont almost 11 years ago

Oops. Last patch was missing cfmakeraw.c.

Actions
Copy link
 #6

Updated by Andrew Stormont almost 11 years ago

Heres an updated patch which I think may be ready to submit. It's also worth noting that APT requires cfmakeraw.

Actions
Copy link
 #7

Updated by Andrew Stormont over 8 years ago

  • % Done changed from 0 to 90
Actions
Copy link
 #8

Updated by Yuri Pankov over 8 years ago

  • Status changed from Feedback to In Progress
  • Tags deleted (needs-triage)
Actions
Copy link
 #9

Updated by Aurélien Larcher about 6 years ago

Any chance to merge this patch into illumos ?

Actions
Copy link
 #10

Updated by Joshua M. Clulow about 2 years ago

  • Related to Bug #12470: raw mode should default to minimum reads of just one byte added
Actions
Copy link
 #11

Updated by Joshua M. Clulow 6 months ago

  • Subject changed from termios missing cfmakeraw to termios needs cfmakeraw and cfsetspeed
  • Assignee changed from Andrew Stormont to Joshua M. Clulow
Actions
Copy link
 #12

Updated by Electric Monk 6 months ago

  • Gerrit CR set to 1808
Actions
Copy link

Also available in: Atom PDF