Project

General

Profile

Feature #1060

termios missing cfmakeraw

Added by Andrew Stormont over 8 years ago. Updated over 3 years ago.

Status:
In Progress
Priority:
Low
Category:
-
Start date:
2011-05-23
Due date:
% Done:

90%

Estimated time:
Difficulty:
Medium
Tags:

Description

The illumos termios implementation is missing cfmakeraw which is provided on Linux, Mac OSX and the BSD's. I decided to come up with a patch (see attached) that implements it because I think it's cleaner than pasting it into the source of things that want it.


Files

cfmakeraw.diff (5.54 KB) cfmakeraw.diff Andrew Stormont, 2011-05-23 12:13 PM
cfmakeraw.diff (4.61 KB) cfmakeraw.diff Andrew Stormont, 2011-06-08 10:38 AM
cfmakeraw.diff (6.16 KB) cfmakeraw.diff Andrew Stormont, 2011-06-08 08:28 PM
cfmakeraw.diff (5.04 KB) cfmakeraw.diff Andrew Stormont, 2011-06-29 03:33 PM

History

#1

Updated by Albert Lee over 8 years ago

Are the struct termios members supposed to be private (i.e. implementation specific)? If so, by all means add this if it's the only way to set the flags without poking the structure.

#2

Updated by Albert Lee over 8 years ago

Nope, http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/termios.h.html says the struct members are public. An extension to the public API when there is a trivial workaround would be against API conservatism, but since the extension is supported almost everywhere else...

#3

Updated by Andrew Stormont over 8 years ago

The members of struct termios are not supposed to be private (afaik) but the steps required to put a termios into raw mode vary across platforms, which is the reason it was created.

#4

Updated by Andrew Stormont over 8 years ago

Attached in an updated patch that alters grub to use cfmakeraw.

#5

Updated by Andrew Stormont over 8 years ago

Oops. Last patch was missing cfmakeraw.c.

#6

Updated by Andrew Stormont over 8 years ago

Heres an updated patch which I think may be ready to submit. It's also worth noting that APT requires cfmakeraw.

#7

Updated by Andrew Stormont about 6 years ago

  • % Done changed from 0 to 90
#8

Updated by Yuri Pankov about 6 years ago

  • Status changed from Feedback to In Progress
  • Tags deleted (needs-triage)
#9

Updated by Aurélien Larcher over 3 years ago

Any chance to merge this patch into illumos ?

Also available in: Atom PDF