Feature #1060
open
termios needs cfmakeraw and cfsetspeed
Added by Andrew Stormont about 11 years ago.
Updated 8 months ago.
Description
The illumos termios implementation is missing cfmakeraw which is provided on Linux, Mac OSX and the BSD's. I decided to come up with a patch (see attached) that implements it because I think it's cleaner than pasting it into the source of things that want it.
Files
Are the struct termios
members supposed to be private (i.e. implementation specific)? If so, by all means add this if it's the only way to set the flags without poking the structure.
The members of struct termios are not supposed to be private (afaik) but the steps required to put a termios into raw mode vary across platforms, which is the reason it was created.
Attached in an updated patch that alters grub to use cfmakeraw.
Oops. Last patch was missing cfmakeraw.c.
Heres an updated patch which I think may be ready to submit. It's also worth noting that APT requires cfmakeraw.
- % Done changed from 0 to 90
- Status changed from Feedback to In Progress
- Tags deleted (
needs-triage)
Any chance to merge this patch into illumos ?
- Related to Bug #12470: raw mode should default to minimum reads of just one byte added
- Subject changed from termios missing cfmakeraw to termios needs cfmakeraw and cfsetspeed
- Assignee changed from Andrew Stormont to Joshua M. Clulow
Also available in: Atom
PDF