Project

General

Profile

Actions

Bug #10611

closed

mouse8042: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-03-30
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Errors with NULL pointer build:

In file included from ../../common/sys/param.h:48:0,
                 from ../../common/io/mouse8042.c:35:
../../common/io/mouse8042.c: In function 'mouse8042_attach':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/mouse8042.c:326:20: note: in expansion of macro 'NULL'
      DDI_NT_MOUSE, NULL);
                    ^~~~
In file included from ../../common/io/mouse8042.c:50:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 9315a2f214fdc5269609ad1be3a248822dabf7f2

commit  9315a2f214fdc5269609ad1be3a248822dabf7f2
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-02T05:49:05.000Z

    10611 mouse8042: NULL pointer errors
    Reviewed by: Rob Johnston <rob.johnston@joyent.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF