Project

General

Profile

Actions

Bug #10627

closed

pcic: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    ../../common/io/pcic.c: In function 'pcic_set_window':
    ../../common/io/pcic.c:2830:20: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
         memp->pcw_base = NULL;
                        ^
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/io/pcic.c:48:
    ../../common/sys/null.h:32:14: error: passing argument 8 of 'pcmcia_map_reg' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/pcic.c:2889:24: note: in expansion of macro 'NULL'
             &window->attr, NULL);
                            ^~~~
    In file included from ../../common/io/pcic.c:75:0:
    ../../common/sys/sservice.h:578:5: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
     int pcmcia_map_reg(dev_info_t *, dev_info_t *, ra_return_t *,
         ^~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit f6c5b04580afc6ac84253f5606169ea6e5920526

commit  f6c5b04580afc6ac84253f5606169ea6e5920526
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-05T05:03:30.000Z

    10627 pcic: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF