Actions
Bug #10630
closed
poll: NULL pointer errors
Start date:
2019-04-01
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
Description
Build errors with NULL pointer:
poll: NULL pointer errors
In file included from ../../common/sys/param.h:48:0,
from ../../common/sys/t_lock.h:38,
from ../../common/sys/buf.h:45,
from ../../common/sys/devops.h:35,
from ../../common/io/devpoll.c:32:
../../common/io/devpoll.c: In function 'dpattach':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
#define NULL ((void *)0)
^
../../common/io/devpoll.c:195:66: note: in expansion of macro 'NULL'
if (ddi_create_minor_node(devi, "poll", S_IFCHR, 0, DDI_PSEUDO, NULL)
^~~~
In file included from ../../common/io/devpoll.c:35:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Updated by Electric Monk about 3 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
git commit 4ff62ce99af7972ca3611aadd6a851b45f2cffcc
commit 4ff62ce99af7972ca3611aadd6a851b45f2cffcc
Author: Toomas Soome <tsoome@me.com>
Date: 2019-04-05T05:06:47.000Z
10630 poll: NULL pointer errors
Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Approved by: Dan McDonald <danmcd@joyent.com>
Actions