Project

General

Profile

Actions

Bug #10634

closed

qlge: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    ../../common/io/fibre-channel/fca/qlge/qlge.c:1162:26: error: comparison between pointer and integer [-Werror]
      if ((sbq_desc->free_buf != NULL) ||
                              ^~
    ../../common/io/fibre-channel/fca/qlge/qlge.c:1164:26: error: comparison between pointer and integer [-Werror]
       if (sbq_desc->free_buf == NULL)
                              ^~
    ../../common/io/fibre-channel/fca/qlge/qlge.c: In function 'ql_refill_lbuf_free_list':
    ../../common/io/fibre-channel/fca/qlge/qlge.c:1275:26: error: comparison between pointer and integer [-Werror]
      if ((lbq_desc->free_buf != NULL) ||
                              ^~
    ../../common/io/fibre-channel/fca/qlge/qlge.c:1277:26: error: comparison between pointer and integer [-Werror]
       if (lbq_desc->free_buf == NULL)
                              ^~
    ../../common/io/fibre-channel/fca/qlge/qlge.c: In function 'ql_send_common':
    ../../common/io/fibre-channel/fca/qlge/qlge.c:5356:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (NULL);
              ^
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 95369d7b997316a0170a6c243bfbfc61d1258fb5

commit  95369d7b997316a0170a6c243bfbfc61d1258fb5
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-10T05:54:49.000Z

    10634 qlge: NULL pointer errors
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF