Project

General

Profile

Actions

Bug #10637

closed

rdsv3: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    ../../common/io/ib/clients/rdsv3/info.c: In function 'rdsv3_info_ioctl':
    ../../common/io/ib/clients/rdsv3/info.c:140:15: error: comparison between pointer and integer [-Werror]
      if (arg.lenp == NULL) {
                   ^~
    ../../common/io/ib/clients/rdsv3/info.c:159:23: error: comparison between pointer and integer [-Werror]
      } else if (arg.datap == NULL) {
                           ^~

    ../../common/io/ib/clients/rdsv3/rdsv3_impl.c: In function 'rdsv3_ib_free_hdrs':
    ../../common/io/ib/clients/rdsv3/rdsv3_impl.c:1303:22: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      ic->i_send_hdrs_dma = NULL;
                          ^
    ../../common/io/ib/clients/rdsv3/rdsv3_impl.c:1306:22: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      ic->i_recv_hdrs_dma = NULL;
                          ^
    ../../common/io/ib/clients/rdsv3/rdsv3_impl.c:1309:16: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      ic->i_ack_dma = NULL;
                    ^
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 9af7e4843362db2afb8704b6c35c03c9dd4ea930

commit  9af7e4843362db2afb8704b6c35c03c9dd4ea930
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-05T16:31:38.000Z

    10637 rdsv3: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF