Project

General

Profile

Actions

Bug #10641

closed

rpcib: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    ../../common/rpc/rpcib.c: In function 'rib_addreplylist':
    ../../common/rpc/rpcib.c:3595:16: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      rep->vaddr_cq = NULL;
                    ^
    ../../common/rpc/rpcib.c: In function 'rib_registermem':
    ../../common/rpc/rpcib.c:3675:25: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       buf_handle->mrc_linfo = NULL;
                             ^
    ../../common/rpc/rpcib.c: In function 'rib_registermemsync':
    ../../common/rpc/rpcib.c:3757:25: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       buf_handle->mrc_linfo = NULL;
                             ^
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/rpc/rpcib.c:45:
    ../../common/rpc/rpcib.c: In function 'rib_get_cache_buf':
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/rpc/rpcib.c:5044:22: note: in expansion of macro 'NULL'
      avl_index_t where = NULL;
                          ^~~~
    ../../common/rpc/rpcib.c: In function 'rib_free_cache_buf':
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/rpc/rpcib.c:5155:22: note: in expansion of macro 'NULL'
      avl_index_t where = NULL;
                          ^~~~
    ../../common/rpc/rpcib.c: In function 'rib_registermem_via_hca':
    ../../common/rpc/rpcib.c:5208:25: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       buf_handle->mrc_linfo = NULL;
                             ^
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 69914347387da227b7bfdf2a3bcb7189eb65eb74

commit  69914347387da227b7bfdf2a3bcb7189eb65eb74
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-05T07:22:14.000Z

    10641 rpcib: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF