Project

General

Profile

Actions

Bug #10643

closed

si3124: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    ../../common/io/sata/adapters/si3124/si3124.c: In function 'si_alloc_sgbpool':
    ../../common/io/sata/adapters/si3124/si3124.c:2038:44: error: comparison between pointer and integer [-Werror]
          &si_portp->siport_sgbpool_acc_handle) != NULL) {
                                                ^~
    ../../common/io/sata/adapters/si3124/si3124.c: In function 'si_alloc_prbpool':
    ../../common/io/sata/adapters/si3124/si3124.c:2117:44: error: comparison between pointer and integer [-Werror]
          &si_portp->siport_prbpool_acc_handle) != NULL) {
                                                ^~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 83dba8e170d701b48549af39323874fe1d568f53

commit  83dba8e170d701b48549af39323874fe1d568f53
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-05T05:38:24.000Z

    10643 si3124: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF