Project

General

Profile

Actions

Bug #10655

closed

emul64: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    ../../common/io/emul64.c: In function 'emul64_scsi_start':
    ../../common/io/emul64.c:1032:14: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       dispatched = NULL;
                  ^
    ../../common/io/emul64.c:1045:19: error: comparison between pointer and integer [-Werror]
        if (dispatched == NULL) {
                       ^~
    ../../common/io/emul64.c:1052:18: error: comparison between pointer and integer [-Werror]
       if (dispatched == NULL) {
                      ^~
    ../../common/io/emul64.c: In function 'emul64_error_inject_req':
    ../../common/io/emul64.c:1154:10: error: comparison between pointer and integer [-Werror]
      if (arg == NULL) {
              ^~
    cc1: all warnings being treated as errors

Actions #1

Updated by Toomas Soome about 3 years ago

  • Subject changed from emul64: NULL poiter errors to emul64: NULL pointer errors
Actions #2

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 2178a880dce2da30d0f5a1ac2913eadd93e9c2ae

commit  2178a880dce2da30d0f5a1ac2913eadd93e9c2ae
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-05T06:08:59.000Z

    10655 emul64: NULL pointer errors
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF