Project

General

Profile

Actions

Bug #10657

closed

ksslf: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    ../../common/inet/kssl/ksslfilter.c: In function 'kssl_input_callback':
    ../../common/inet/kssl/ksslfilter.c:566:18: error: comparison between pointer and integer [-Werror]
          TQ_NOSLEEP) == NULL) {
                      ^~

    ../../common/inet/kssl/ksslapi.c: In function 'kssl_handle_mblk':
    ../../common/inet/kssl/ksslapi.c:557:12: error: incompatible types when returning type 'void *' but 'kssl_cmd_t {aka enum <anonymous>}' was expected
         return (NULL);
                ^

    ../../common/inet/kssl/ksslrec.c: In function 'kssl_free_context':
    ../../common/inet/kssl/ksslrec.c:2491:21: error: comparison between pointer and integer [-Werror]
       if (ssl->job.kjob != NULL) {
                         ^~
    ../../common/inet/kssl/ksslrec.c:2503:22: error: comparison between pointer and integer [-Werror]
        if (ssl->job.kjob != NULL) {
                          ^~
    ../../common/inet/kssl/ksslrec.c:2512:25: error: comparison between pointer and integer [-Werror]
      } while (ssl->job.kjob != NULL);
                             ^~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 7a31d868f4fe5807fc1f2c366518428c223128ef

commit  7a31d868f4fe5807fc1f2c366518428c223128ef
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-19T21:16:24.000Z

    10657 ksslf: NULL pointer errors
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF