Project

General

Profile

Actions

Bug #10658

closed

kiconv_ja: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build error with NULL pointer:

    ../../common/kiconv/kiconv_ja/kiconv_ja.c: In function '_do_kiconvstr_fr_eucjp':
    ../../common/kiconv/kiconv_ja/kiconv_ja.c:529:33: error: comparison between pointer and integer [-Werror]
      if ((inbuf == NULL) || (*inbuf == NULL)) {
                                     ^~
    ../../common/kiconv/kiconv_ja/kiconv_ja.c: In function '_do_kiconvstr_to_eucjp':
    ../../common/kiconv/kiconv_ja/kiconv_ja.c:679:33: error: comparison between pointer and integer [-Werror]
      if ((inbuf == NULL) || (*inbuf == NULL)) {
                                     ^~
    ../../common/kiconv/kiconv_ja/kiconv_ja.c: In function '_do_kiconvstr_fr_sjis':
    ../../common/kiconv/kiconv_ja/kiconv_ja.c:1138:33: error: comparison between pointer and integer [-Werror]
      if ((inbuf == NULL) || (*inbuf == NULL)) {
                                     ^~
    ../../common/kiconv/kiconv_ja/kiconv_ja.c: In function '_do_kiconvstr_to_sjis':
    ../../common/kiconv/kiconv_ja/kiconv_ja.c:1372:33: error: comparison between pointer and integer [-Werror]
      if ((inbuf == NULL) || (*inbuf == NULL)) {
                                     ^~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 2667222682da9a362b1246a1e39cdaf1f38cb56e

commit  2667222682da9a362b1246a1e39cdaf1f38cb56e
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-10T06:05:18.000Z

    10658 kiconv_ja: NULL pointer errors
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF