Project

General

Profile

Actions
Copy link

Bug #10666

closed

amd8111s: NULL pointer errors

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2019-04-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors with NULL pointer:

    ../../intel/io/amd8111s/amd8111s_main.c: In function 'amd8111s_odlInit':
    ../../intel/io/amd8111s/amd8111s_main.c:708:24: error: comparison between pointer and integer [-Werror]
        if (*pmem_set_array == NULL)
                            ^~
    ../../intel/io/amd8111s/amd8111s_main.c:723:19: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       *pmem_set_array = NULL;
                       ^
    ../../intel/io/amd8111s/amd8111s_main.c:733:19: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       *pmem_set_array = NULL;
                       ^
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 0f36d2f14c16f2aa8dbbd72241001f534f1ca1b2

commit  0f36d2f14c16f2aa8dbbd72241001f534f1ca1b2
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-10T06:01:16.000Z

    10666 amd8111s: NULL pointer errors
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF