Project

General

Profile

Actions

Bug #10676

closed

fbt: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
DTrace
Start date:
2019-04-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

../../intel/dtrace/fbt.c: In function 'fbt_invop':
../../intel/dtrace/fbt.c:120:28: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
     CPU->cpu_dtrace_caller = NULL;
                            ^
../../intel/dtrace/fbt.c:137:28: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
     CPU->cpu_dtrace_caller = NULL;
                            ^
../../intel/dtrace/fbt.c: In function 'fbt_provide_module':
../../intel/dtrace/fbt.c:186:55: error: comparison between pointer and integer [-Werror]
  if (str == NULL || symhdr == NULL || symhdr->sh_addr == NULL) {
                                                       ^~
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/sys/t_lock.h:38,
                 from ../../common/sys/thread.h:36,
                 from ../../common/sys/modctl.h:35,
                 from ../../intel/dtrace/fbt.c:27:
../../intel/dtrace/fbt.c: In function 'fbt_attach':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../intel/dtrace/fbt.c:724:18: note: in expansion of macro 'NULL'
      DDI_PSEUDO, NULL) == DDI_FAILURE ||
                  ^~~~
In file included from ../../intel/dtrace/fbt.c:32:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 68deb3360e8e161517e8eda768aa13357247893e

commit  68deb3360e8e161517e8eda768aa13357247893e
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-11T18:15:52.000Z

    10676 fbt: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF