Project

General

Profile

Bug #10680

fasttrap: NULL pointer errors

Added by Toomas Soome 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
DTrace
Start date:
2019-04-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Build errors with NULL pointer:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/thread.h:36,
                     from ../../common/sys/modctl.h:35,
                     from ../../common/dtrace/fasttrap.c:34:
    ../../common/dtrace/fasttrap.c: In function 'fasttrap_attach':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/dtrace/fasttrap.c:2137:18: note: in expansion of macro 'NULL'
          DDI_PSEUDO, NULL) == DDI_FAILURE) {
                      ^~~~
    In file included from ../../common/dtrace/fasttrap.c:38:0:
    ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
     ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 7 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit ef623aa14b0dc34c6b9edb213cbcda88461ecfc3

commit  ef623aa14b0dc34c6b9edb213cbcda88461ecfc3
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-11T18:25:19.000Z

    10680 fasttrap: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF