Project

General

Profile

Actions

Bug #10699

closed

loader: smatch cleanups for ficl

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2019-04-07
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Additional cleanup for issues the libficl-sys build did not reveal.

Actions #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit c0bb4f7308f9d7f3f31eb636c73ef07c6d19b5f3

commit  c0bb4f7308f9d7f3f31eb636c73ef07c6d19b5f3
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-29T15:19:42.000Z

    10606 ficl: smatch errors: inconsistent indenting and unchecked function return
    10699 loader: smatch cleanups for ficl
    10885 loader: ficl pfopendir() should push FICL_FALSE in case of error
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF