Project

General

Profile

Bug #10709

ses: NULL pointer errors

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2019-04-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

NULL pointer errors:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/thread.h:36,
                     from ../../common/sys/modctl.h:35,
                     from ../../common/io/scsi/targets/ses.c:30:
    ../../common/io/scsi/targets/ses.c: In function 'ses_doattach':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/scsi/targets/ses.c:445:29: note: in expansion of macro 'NULL'
          DDI_NT_SCSI_ENCLOSURE, NULL);
                                 ^~~~
    In file included from ../../common/sys/scsi/scsi_types.h:61:0,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/scsi/targets/ses.c:32:
    ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
     ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 87496ca1b8a7e4dcd91aa9ecf7eb8f150669a17f

commit  87496ca1b8a7e4dcd91aa9ecf7eb8f150669a17f
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-18T05:26:39.000Z

    10709 ses: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF