Project

General

Profile

Bug #10712

iscsi: NULL pointer errors

Added by Toomas Soome 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

NULL pointer errors:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/file.h:35,
                     from ../../common/sys/t_kuser.h:46,
                     from ../../common/sys/bootprops.h:31,
                     from ../../common/io/scsi/adapters/iscsi/iscsi_sess.c:27:
    ../../common/io/scsi/adapters/iscsi/iscsi_sess.c: In function 'iscsi_sess_state_machine':
    ../../common/sys/null.h:32:14: error: passing argument 5 of 'idm_sm_audit_event' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/scsi/adapters/iscsi/iscsi_sess.c:1097:46: note: in expansion of macro 'NULL'
          SAS_ISCSI_SESS, isp->sess_state, event, NULL);
                                                  ^~~~
    In file included from ../../common/io/scsi/adapters/iscsi/iscsi.h:56:0,
                     from ../../common/io/scsi/adapters/iscsi/iscsi_sess.c:28:
    ../../common/sys/idm/idm.h:274:6: note: expected 'uintptr_t {aka long unsigned int}' but argument is of type 'void *'
     void idm_sm_audit_event(sm_audit_buf_t *audit_buf,
          ^~~~~~~~~~~~~~~~~~

    ../../common/io/scsi/adapters/iscsi/iscsi_io.c: In function 'iscsi_wd_thread':
    ../../common/io/scsi/adapters/iscsi/iscsi_io.c:3397:12: error: comparison between pointer and integer [-Werror]
      while (rc != NULL) {
                ^~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 7 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 811eca55ab39bdff2ebf68281580720b7732dd51

commit  811eca55ab39bdff2ebf68281580720b7732dd51
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-19T21:23:58.000Z

    10712 iscsi: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF