Project

General

Profile

Actions

Bug #10713

closed

fp: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

NULL pointer errors:

    ../../common/io/fibre-channel/impl/fp.c: In function 'fp_unsol_cb':
    ../../common/io/fibre-channel/impl/fp.c:10905:56: error: pointer/integer type mismatch in conditional expression [-Werror]
      cb_arg = (rscn_count == FC_INVALID_RSCN_COUNT) ? NULL : rscn_count;
                                                            ^
    ../../common/io/fibre-channel/impl/fp.c:10905:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      cb_arg = (rscn_count == FC_INVALID_RSCN_COUNT) ? NULL : rscn_count;
             ^
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit fbcf87a4562106add38912a718bcd42a9e2c479f

commit  fbcf87a4562106add38912a718bcd42a9e2c479f
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-19T21:26:50.000Z

    10713 fp: NULL pointer errors
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF