Project

General

Profile

Bug #10714

usbser: NULL pointer errors

Added by Toomas Soome 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

NULL pointer errors:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/io/usb/clients/usbser/usbser.c:33:
    ../../common/io/usb/clients/usbser/usbser.c: In function 'usbser_create_port_minor_nodes':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/usb/clients/usbser/usbser.c:904:37: note: in expansion of macro 'NULL'
          S_IFCHR, minor, DDI_NT_SERIAL, NULL) != DDI_SUCCESS) {
                                         ^~~~
    In file included from ../../common/io/usb/clients/usbser/usbser.c:42:0:
    ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
     ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/io/usb/clients/usbser/usbser.c:33:
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/usb/clients/usbser/usbser.c:916:40: note: in expansion of macro 'NULL'
          S_IFCHR, minor, DDI_NT_SERIAL_DO, NULL) != DDI_SUCCESS) {
                                            ^~~~
    In file included from ../../common/io/usb/clients/usbser/usbser.c:42:0:
    ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
     ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 7 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit be128d9b799db5fcf41805a4eccc8b9c9199d5e3

commit  be128d9b799db5fcf41805a4eccc8b9c9199d5e3
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-18T05:29:01.000Z

    10714 usbser: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF