Project

General

Profile

Bug #10716

usbvc: NULL pointer errors

Added by Toomas Soome 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

NULL pointer errors:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/conf.h:37,
                     from ../../common/sys/usb/usba.h:34,
                     from ../../common/io/usb/clients/video/usbvc/usbvc.c:153:
    ../../common/io/usb/clients/video/usbvc/usbvc.c: In function 'usbvc_read':
    ../../common/sys/null.h:32:14: error: passing argument 3 of 'usbvc_start_isoc_polling' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/usb/clients/video/usbvc/usbvc.c:811:49: note: in expansion of macro 'NULL'
       if (usbvc_start_isoc_polling(usbvcp, strm_if, NULL) !=
                                                     ^~~~
    In file included from ../../common/io/usb/clients/video/usbvc/usbvc.c:156:0:
    ../../common/sys/usb/clients/video/usbvc/usbvc_var.h:369:5: note: expected 'uchar_t {aka unsigned char}' but argument is of type 'void *'
     int usbvc_start_isoc_polling(usbvc_state_t *, usbvc_stream_if_t *, uchar_t);
         ^~~~~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 7 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 11b5d82fcd2fe348d89f47fa6e7abbcd64f9948b

commit  11b5d82fcd2fe348d89f47fa6e7abbcd64f9948b
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-22T19:45:09.000Z

    10716 usbvc: NULL pointer errors
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF