Actions
Bug #10718
closedav1394: NULL pointer errors
Start date:
2019-04-10
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
NULL pointer errors:
In file included from ../../common/sys/param.h:48:0, from ../../common/sys/t_lock.h:38, from ../../common/sys/file.h:35, from ../../common/io/1394/targets/av1394/av1394_async.c:35: ../../common/io/1394/targets/av1394/av1394_async.c: In function 'av1394_async_create_minor_node': ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion] #define NULL ((void *)0) ^ ../../common/io/1394/targets/av1394/av1394_async.c:447:23: note: in expansion of macro 'NULL' DDI_NT_AV_ASYNC, NULL); ^~~~ In file included from ../../common/sys/param.h:48:0, from ../../common/sys/t_lock.h:38, from ../../common/sys/file.h:35, from ../../common/io/1394/targets/av1394/av1394_isoch.c:30: ../../common/io/1394/targets/av1394/av1394_isoch.c: In function 'av1394_isoch_create_minor_node': ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion] #define NULL ((void *)0) ^ ../../common/io/1394/targets/av1394/av1394_isoch.c:321:23: note: in expansion of macro 'NULL' DDI_NT_AV_ISOCH, NULL); ^~~~ In file included from ../../common/io/1394/targets/av1394/av1394_isoch.c:32:0: ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *' ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type, ^~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors
Updated by Electric Monk over 4 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
git commit 92548b6ca1ae8b76e54b19801f96b5f6eb4e836d
commit 92548b6ca1ae8b76e54b19801f96b5f6eb4e836d Author: Toomas Soome <tsoome@me.com> Date: 2019-04-19T21:34:36.000Z 10718 av1394: NULL pointer errors Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net> Reviewed by: Robert Mustacchi <rm@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>
Actions