Actions
Bug #10724
closeddaplt: NULL pointer errors
Start date:
2019-04-10
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
Description
NULL pointer errors:
In file included from ../../common/sys/param.h:48:0, from ../../common/sys/t_lock.h:38, from ../../common/sys/conf.h:37, from ../../common/sys/stropts.h:38, from ../../common/io/ib/clients/daplt/daplt.c:32: ../../common/io/ib/clients/daplt/daplt.c: In function 'daplka_attach': ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion] #define NULL ((void *)0) ^ ../../common/io/ib/clients/daplt/daplt.c:976:21: note: in expansion of macro 'NULL' 0, DDI_PSEUDO, NULL) != DDI_SUCCESS) { ^~~~ In file included from ../../common/io/ib/clients/daplt/daplt.c:42:0: ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *' ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type, ^~~~~~~~~~~~~~~~~~~~~ ../../common/io/ib/clients/daplt/daplt.c: In function 'daplka_mr_destroy': ../../common/io/ib/clients/daplt/daplt.c:5389:26: error: assignment makes integer from pointer without a cast [-Werror=int-conversion] mr_rp->mr_attr.mr_vaddr = NULL; ^ ../../common/io/ib/clients/daplt/daplt.c: In function 'daplka_dbglog': ../../common/io/ib/clients/daplt/daplt.c:9888:47: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] daplka_dbgbuf[sizeof (daplka_dbgbuf) - 1] = (char)NULL; ^ cc1: all warnings being treated as errors
Updated by Electric Monk about 3 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
git commit e40570dd557d185d2eef1f1970de92ae17fd6cb0
commit e40570dd557d185d2eef1f1970de92ae17fd6cb0 Author: Toomas Soome <tsoome@me.com> Date: 2019-04-19T21:41:58.000Z 10724 daplt: NULL pointer errors Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net> Reviewed by: Robert Mustacchi <rm@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>
Actions