Project

General

Profile

Bug #10731

zfs: NULL pointer errors

Added by Toomas Soome 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
2019-04-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

NULL pointer errors:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/fs/zfs/sys/zfs_context.h:40,
                     from ../../common/fs/zfs/lua/lua.h:12,
                     from ../../common/fs/zfs/zcp_synctask.c:20:
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:107:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_synctask_destroy_info.pargs[1].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:107:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:111:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_synctask_destroy_info.kwargs[1].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:111:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:160:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_synctask_promote_info.pargs[1].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:160:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:163:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_synctask_promote_info.kwargs[0].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:163:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:199:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_synctask_rollback_info.pargs[1].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:199:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:202:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_synctask_rollback_info.kwargs[0].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:202:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:229:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_synctask_snapshot_info.pargs[1].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:229:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:232:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_synctask_snapshot_info.kwargs[0].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_synctask.c:232:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/fs/zfs/sys/zfs_context.h:40,
                     from ../../common/fs/zfs/lua/lua.h:12,
                     from ../../common/fs/zfs/zcp_iter.c:20:
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:113:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_clones_list_info.pargs[1].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:113:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:116:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_clones_list_info.kwargs[0].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:116:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:202:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_snapshots_list_info.pargs[1].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:202:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:205:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_snapshots_list_info.kwargs[0].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:205:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:303:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_children_list_info.pargs[1].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:303:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:306:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_children_list_info.kwargs[0].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:306:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:384:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_props_list_info.pargs[1].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:384:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:387:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_props_list_info.kwargs[0].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:387:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:442:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_system_props_list_info.pargs[1].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:442:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:445:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_system_props_list_info.kwargs[0].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_iter.c:445:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/fs/zfs/sys/zfs_context.h:40,
                     from ../../common/fs/zfs/lua/lua.h:12,
                     from ../../common/fs/zfs/sys/zcp_global.h:23,
                     from ../../common/fs/zfs/zcp_global.c:20:
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_global.c:71:9: note: in expansion of macro 'NULL'
      {NULL, NULL}
             ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'errno_globals[40].zeg_errno')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_global.c:71:9: note: in expansion of macro 'NULL'
      {NULL, NULL}
             ^~~~

    In file included from ../../common/sys/model.h:35:0,
                     from ../../common/sys/resource.h:221,
                     from ../../common/sys/user.h:73,
                     from ../../common/sys/proc.h:36,
                     from ../../common/sys/systm.h:40,
                     from ../../common/fs/zfs/sys/zfs_context.h:50,
                     from ../../common/fs/zfs/lua/lua.h:12,
                     from ../../common/fs/zfs/zcp_get.c:20:
    ../../common/fs/zfs/zcp_get.c: In function 'get_special_prop':
    ../../common/sys/null.h:32:14: error: passing argument 4 of 'zcp_nvlist_to_lua' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/sys/debug.h:105:29: note: in definition of macro 'VERIFY3_IMPL'
      const TYPE __left = (TYPE)(LEFT); \
                                 ^~~~
    ../../common/fs/zfs/zcp_get.c:333:4: note: in expansion of macro 'VERIFY0'
        VERIFY0(zcp_nvlist_to_lua(state, clones, NULL,
        ^~~~~~~
    ../../common/fs/zfs/zcp_get.c:334:8: note: in expansion of macro 'NULL'
            NULL));
            ^~~~
    In file included from ../../common/fs/zfs/zcp_get.c:34:0:
    ../../common/fs/zfs/sys/zcp.h:137:5: note: expected 'int' but argument is of type 'void *'
     int zcp_nvlist_to_lua(lua_State *, nvlist_t *, char *, int);
         ^~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/fs/zfs/sys/zfs_context.h:40,
                     from ../../common/fs/zfs/lua/lua.h:12,
                     from ../../common/fs/zfs/zcp_get.c:20:
    ../../common/fs/zfs/zcp_get.c: At top level:
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_get.c:795:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_get_prop_info.pargs[2].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_get.c:795:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_get.c:798:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_get_prop_info.kwargs[0].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp_get.c:798:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~

    ../../common/fs/zfs/zcp.c: In function 'zcp_dataset_hold_error':
    ../../common/fs/zfs/zcp.c:611:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (NULL); /* not reached; zcp_argerror will longjmp */
              ^
    ../../common/fs/zfs/zcp.c:616:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (NULL); /* not reached; zcp_argerror will longjmp */
              ^
    ../../common/fs/zfs/zcp.c:620:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (NULL); /* not reached; luaL_error will longjmp */
              ^
    ../../common/fs/zfs/zcp.c:625:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (NULL); /* not reached; luaL_error will longjmp */
              ^
    ../../common/fs/zfs/zcp.c:627:9: error: return makes integer from pointer without a cast [-Werror=int-conversion]
      return (NULL);
             ^
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/fs/zfs/sys/zfs_context.h:40,
                     from ../../common/fs/zfs/lua/lua.h:12,
                     from ../../common/fs/zfs/zcp.c:92:
    ../../common/fs/zfs/zcp.c: At top level:
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp.c:650:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_debug_info.pargs[1].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp.c:650:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp.c:653:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_debug_info.kwargs[0].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp.c:653:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp.c:679:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_exists_info.pargs[1].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp.c:679:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp.c:682:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'zcp_exists_info.kwargs[0].za_lua_type')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/zcp.c:682:13: note: in expansion of macro 'NULL'
          {NULL, NULL}
                 ^~~~

    In file included from ../../common/sys/model.h:35:0,
                     from ../../common/sys/resource.h:221,
                     from ../../common/sys/user.h:73,
                     from ../../common/sys/proc.h:36,
                     from ../../common/sys/systm.h:40,
                     from ../../common/fs/zfs/sys/zfs_context.h:50,
                     from ../../common/fs/zfs/vdev.c:31:
    ../../common/fs/zfs/vdev.c: In function 'vdev_open_children':
    ../../common/fs/zfs/vdev.c:1371:17: error: comparison between pointer and integer [-Werror]
           TQ_SLEEP) != NULL);
                     ^
    ../../common/sys/debug.h:57:29: note: in definition of macro 'VERIFY'
     #define VERIFY(EX) ((void)((EX) || assfail(#EX, __FILE__, __LINE__)))
                                 ^~

    ../../common/fs/zfs/sa.c: In function 'sa_attr_register_sync':
    ../../common/fs/zfs/sa.c:1580:58: error: comparison between pointer and integer [-Werror]
      if (!sa->sa_need_attr_registration || sa->sa_master_obj == NULL) {
                                                              ^~
    ../../common/fs/zfs/sa.c:1585:26: error: comparison between pointer and integer [-Werror]
      if (sa->sa_reg_attr_obj == NULL) {
                              ^~

    ../../common/fs/zfs/metaslab.c: In function 'metaslab_group_preload':
    ../../common/fs/zfs/metaslab.c:2159:22: error: comparison between pointer and integer [-Werror]
           msp, TQ_SLEEP) != NULL);
                          ^
    ../../common/sys/debug.h:57:29: note: in definition of macro 'VERIFY'
     #define VERIFY(EX) ((void)((EX) || assfail(#EX, __FILE__, __LINE__)))
                                 ^~

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/fs/zfs/sys/zfs_context.h:40,
                     from ../../common/fs/zfs/sys/spa.h:36,
                     from ../../common/fs/zfs/sys/dsl_pool.h:30,
                     from ../../common/fs/zfs/dsl_pool.c:30:
    ../../common/fs/zfs/dsl_pool.c: In function 'dsl_pool_user_release':
    ../../common/sys/null.h:32:14: error: passing argument 4 of 'dsl_pool_user_hold_rele_impl' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/zfs/dsl_pool.c:1150:55: note: in expansion of macro 'NULL'
      return (dsl_pool_user_hold_rele_impl(dp, dsobj, tag, NULL,
                                                           ^~~~
    ../../common/fs/zfs/dsl_pool.c:1099:1: note: expected 'uint64_t {aka long unsigned int}' but argument is of type 'void *'
     dsl_pool_user_hold_rele_impl(dsl_pool_t *dp, uint64_t dsobj,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

    ../../common/fs/zfs/zfs_ioctl.c: In function 'history_str_get':
    ../../common/fs/zfs/zfs_ioctl.c:309:21: error: comparison between pointer and integer [-Werror]
      if (zc->zc_history == NULL)
                         ^~
    ../../common/fs/zfs/zfs_ioctl.c: In function 'zfs_ioc_objset_zplprops':
    ../../common/fs/zfs/zfs_ioctl.c:2224:24: error: comparison between pointer and integer [-Werror]
      if (zc->zc_nvlist_dst != NULL &&
                            ^~
    ../../common/fs/zfs/zfs_ioctl.c: In function 'zfs_ioc_set_prop':
    ../../common/fs/zfs/zfs_ioctl.c:2781:24: error: comparison between pointer and integer [-Werror]
      if (zc->zc_nvlist_dst != NULL && errors != NULL) {
                            ^~
    ../../common/fs/zfs/zfs_ioctl.c: In function 'zfs_ioc_pool_get_props':
    ../../common/fs/zfs/zfs_ioctl.c:2932:38: error: comparison between pointer and integer [-Werror]
      if (error == 0 && zc->zc_nvlist_dst != NULL)
                                          ^~
    ../../common/fs/zfs/zfs_ioctl.c: In function 'zfs_ioc_recv':
    ../../common/fs/zfs/zfs_ioctl.c:4404:24: error: comparison between pointer and integer [-Werror]
      if (zc->zc_nvlist_src != NULL &&
                            ^~
    ../../common/fs/zfs/zfs_ioctl.c: In function 'zfs_ioc_clear':
    ../../common/fs/zfs/zfs_ioctl.c:4828:25: error: comparison between pointer and integer [-Werror]
       if (zc->zc_nvlist_src == NULL)
                             ^~

    ../../common/fs/zfs/zil.c: In function 'zil_clean':
    ../../common/fs/zfs/zil.c:1910:62: error: comparison between pointer and integer [-Werror]
          (void (*)(void *))zil_itxg_clean, clean_me, TQ_NOSLEEP) == NULL)
                                                                  ^~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 5 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit dd328bf6d39366b8d7bde6a36114538fc14332dd

commit  dd328bf6d39366b8d7bde6a36114538fc14332dd
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-23T17:08:28.000Z

    10731 zfs: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF