Project

General

Profile

Bug #10735

pcfs: NULL pointer errors

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
filesystems (not ZFS)
Start date:
2019-04-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

NULL pointer errors:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/fs/pcfs/pc_vfsops.c:30:
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/pcfs/pc_vfsops.c:121:55: note: in expansion of macro 'NULL'
      { MNTOPT_PCFS_NOCLAMPTIME, noclamptime_cancel, NULL, NULL, NULL },
                                                           ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'mntopts[5].mo_flags')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/pcfs/pc_vfsops.c:121:55: note: in expansion of macro 'NULL'
      { MNTOPT_PCFS_NOCLAMPTIME, noclamptime_cancel, NULL, NULL, NULL },
                                                           ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/pcfs/pc_vfsops.c:122:42: note: in expansion of macro 'NULL'
      { MNTOPT_NOATIME, noatime_cancel, NULL, NULL, NULL },
                                              ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'mntopts[6].mo_flags')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/pcfs/pc_vfsops.c:122:42: note: in expansion of macro 'NULL'
      { MNTOPT_NOATIME, noatime_cancel, NULL, NULL, NULL },
                                              ^~~~
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/fs/pcfs/pc_vfsops.c:123:38: note: in expansion of macro 'NULL'
      { MNTOPT_ATIME, atime_cancel, NULL, NULL, NULL },
                                          ^~~~
    ../../common/sys/null.h:32:14: note: (near initialization for 'mntopts[7].mo_flags')
     #define NULL ((void *)0)
                  ^
    ../../common/fs/pcfs/pc_vfsops.c:123:38: note: in expansion of macro 'NULL'
      { MNTOPT_ATIME, atime_cancel, NULL, NULL, NULL },
                                          ^~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Toomas Soome over 1 year ago

  • Subject changed from pcfs: NNUNLL pointer errors to pcfs: NULL pointer errors
#2

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 80a3d255988c2133ae94f26127fbbfdd9d9ed620

commit  80a3d255988c2133ae94f26127fbbfdd9d9ed620
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-19T22:06:08.000Z

    10735 pcfs: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF