Project

General

Profile

Bug #10750

s1394: NULL pointer errors

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2019-04-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

NULL pointer errors:

    ../../common/io/1394/s1394_hotplug.c: In function 's1394_devi_find':
    ../../common/io/1394/s1394_hotplug.c:447:17: error: comparison between pointer and integer [-Werror]
       if (regptr[2] != NULL || regptr[3] != NULL) {
                     ^~
    ../../common/io/1394/s1394_hotplug.c:447:38: error: comparison between pointer and integer [-Werror]
       if (regptr[2] != NULL || regptr[3] != NULL) {
                                          ^~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 1a18250823b44e2190da89fc4551f4cbccb7bbb9

commit  1a18250823b44e2190da89fc4551f4cbccb7bbb9
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-19T22:35:16.000Z

    10750 s1394: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF