Project

General

Profile

Actions
Copy link

Bug #10759

closed

cardbus: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2019-04-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

NULL pointer errors:

    ../../common/io/cardbus/cardbus.c: In function 'find_token':
    ../../common/io/cardbus/cardbus.c:1446:7: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      **cp = NULL;
           ^
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/conf.h:37,
                     from ../../common/io/cardbus/cardbus.c:38:
    ../../common/io/cardbus/cardbus.c: In function 'cardbus_parse_devprop':
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cardbus/cardbus.c:1608:12: note: in expansion of macro 'NULL'
      char eq = NULL;
                ^~~~
    ../../common/io/cardbus/cardbus.c:1637:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
        *cpp = NULL;
             ^
    ../../common/io/cardbus/cardbus.c:1648:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
         *cp = NULL;
             ^
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 152f805526ab714ed4b76c4ff672f34c8dda62ea

commit  152f805526ab714ed4b76c4ff672f34c8dda62ea
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-16T04:53:20.000Z

    10759 cardbus: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF