Project

General

Profile

Actions
Copy link

Bug #10760

closed

cmlb: NULL pointer errors

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2019-04-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

NULL pointer errors:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/io/cmlb.c: In function 'cmlb_create_minor_nodes':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'cmlb_create_minor' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:1497:26: note: in expansion of macro 'NULL'
            cl->cl_node_type, NULL, internal) == DDI_FAILURE) {
                              ^~~~
    ../../common/io/cmlb.c:1420:1: note: expected 'int' but argument is of type 'void *'
     cmlb_create_minor(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'cmlb_create_minor' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:1572:25: note: in expansion of macro 'NULL'
           cl->cl_node_type, NULL, internal);
                             ^~~~
    ../../common/io/cmlb.c:1420:1: note: expected 'int' but argument is of type 'void *'
     cmlb_create_minor(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'cmlb_create_minor' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:1575:25: note: in expansion of macro 'NULL'
           cl->cl_node_type, NULL, internal);
                             ^~~~
    ../../common/io/cmlb.c:1420:1: note: expected 'int' but argument is of type 'void *'
     cmlb_create_minor(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'cmlb_create_minor' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:1582:25: note: in expansion of macro 'NULL'
           cl->cl_node_type, NULL, internal);
                             ^~~~
    ../../common/io/cmlb.c:1420:1: note: expected 'int' but argument is of type 'void *'
     cmlb_create_minor(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'cmlb_create_minor' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:1585:25: note: in expansion of macro 'NULL'
           cl->cl_node_type, NULL, internal);
                             ^~~~
    ../../common/io/cmlb.c:1420:1: note: expected 'int' but argument is of type 'void *'
     cmlb_create_minor(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/io/cmlb.c: In function 'cmlb_update_ext_minor_nodes':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'cmlb_create_minor' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:2124:25: note: in expansion of macro 'NULL'
           cl->cl_node_type, NULL, internal) == DDI_FAILURE) {
                             ^~~~
    ../../common/io/cmlb.c:1420:1: note: expected 'int' but argument is of type 'void *'
     cmlb_create_minor(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:2138:25: note: in expansion of macro 'NULL'
           cl->cl_node_type, NULL) == DDI_FAILURE) {
                             ^~~~
    In file included from ../../common/sys/scsi/scsi_types.h:61:0,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
     ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/io/cmlb.c: In function 'cmlb_dkio_set_vtoc':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'cmlb_create_minor' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:4419:24: note: in expansion of macro 'NULL'
          cl->cl_node_type, NULL, internal);
                            ^~~~
    ../../common/io/cmlb.c:1420:1: note: expected 'int' but argument is of type 'void *'
     cmlb_create_minor(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'cmlb_create_minor' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:4422:24: note: in expansion of macro 'NULL'
          cl->cl_node_type, NULL, internal);
                            ^~~~
    ../../common/io/cmlb.c:1420:1: note: expected 'int' but argument is of type 'void *'
     cmlb_create_minor(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/io/cmlb.c: In function 'cmlb_dkio_set_extvtoc':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'cmlb_create_minor' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:4507:24: note: in expansion of macro 'NULL'
          cl->cl_node_type, NULL, internal);
                            ^~~~
    ../../common/io/cmlb.c:1420:1: note: expected 'int' but argument is of type 'void *'
     cmlb_create_minor(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'cmlb_create_minor' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:4510:24: note: in expansion of macro 'NULL'
          cl->cl_node_type, NULL, internal);
                            ^~~~
    ../../common/io/cmlb.c:1420:1: note: expected 'int' but argument is of type 'void *'
     cmlb_create_minor(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/io/cmlb.c: In function 'cmlb_dkio_set_efi':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'cmlb_create_minor' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:5029:26: note: in expansion of macro 'NULL'
            cl->cl_node_type, NULL, internal);
                              ^~~~
    ../../common/io/cmlb.c:1420:1: note: expected 'int' but argument is of type 'void *'
     cmlb_create_minor(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/scsi/scsi_types.h:39,
                     from ../../common/sys/scsi/scsi.h:36,
                     from ../../common/io/cmlb.c:34:
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'cmlb_create_minor' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/cmlb.c:5033:26: note: in expansion of macro 'NULL'
            cl->cl_node_type, NULL, internal);
                              ^~~~
    ../../common/io/cmlb.c:1420:1: note: expected 'int' but argument is of type 'void *'
     cmlb_create_minor(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 531d0b660fda0e50182e7d981c4eb2391f6528e2

commit  531d0b660fda0e50182e7d981c4eb2391f6528e2
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-18T05:54:12.000Z

    10760 cmlb: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF