Project

General

Profile

Actions

Bug #10765

closed

acpica: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

NULL pointer errors:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/conf.h:37,
                     from ../../i86pc/sys/psm.h:40,
                     from ../../intel/io/acpica/osl.c:37:
    ../../intel/io/acpica/osl.c: In function 'AcpiOsGetRootPointer':
    ../../common/sys/null.h:32:14: error: passing argument 5 of 'ddi_prop_get_int64' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../intel/io/acpica/osl.c:233:42: note: in expansion of macro 'NULL'
          DDI_PROP_DONTPASS, "acpi-root-tab", NULL);
                                              ^~~~
    In file included from ../../i86pc/sys/psm.h:42:0,
                     from ../../intel/io/acpica/osl.c:37:
    ../../common/sys/sunddi.h:736:9: note: expected 'int64_t {aka long int}' but argument is of type 'void *'
     int64_t ddi_prop_get_int64(dev_t match_dev, dev_info_t *dip, uint_t flags,
             ^~~~~~~~~~~~~~~~~~
    ../../intel/io/acpica/osl.c:235:15: error: comparison between pointer and integer [-Werror]
      if ((Address == NULL) && ACPI_FAILURE(AcpiFindRootPointer(&Address)))
                   ^~
    ../../intel/io/acpica/osl.c:236:11: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       Address = NULL;
               ^
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit ee4417888cf835db6efb1e9b8039c90f0674e1cd

commit  ee4417888cf835db6efb1e9b8039c90f0674e1cd
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-23T20:10:58.000Z

    10765 acpica: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF