Project

General

Profile

Bug #10771

ibmf: NULL pointer errors

Added by Toomas Soome 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

NULL pointer errors:

    ../../common/io/ib/mgt/ibmf/ibmf_wqe.c: In function 'ibmf_send_wqe_cache_constructor':
    ../../common/io/ib/mgt/ibmf/ibmf_wqe.c:90:28: error: comparison between pointer and integer [-Werror]
      if (send_wqe->send_sg_mem == NULL) {
                                ^~
    ../../common/io/ib/mgt/ibmf/ibmf_wqe.c: In function 'ibmf_recv_wqe_cache_constructor':
    ../../common/io/ib/mgt/ibmf/ibmf_wqe.c:202:28: error: comparison between pointer and integer [-Werror]
      if (recv_wqe->recv_sg_mem == NULL) {
                                ^~
    ../../common/io/ib/mgt/ibmf/ibmf_wqe.c: In function 'ibmf_altqp_send_wqe_cache_constructor':
    ../../common/io/ib/mgt/ibmf/ibmf_wqe.c:315:28: error: comparison between pointer and integer [-Werror]
      if (send_wqe->send_sg_mem == NULL) {
                                ^~
    ../../common/io/ib/mgt/ibmf/ibmf_wqe.c: In function 'ibmf_altqp_recv_wqe_cache_constructor':
    ../../common/io/ib/mgt/ibmf/ibmf_wqe.c:428:28: error: comparison between pointer and integer [-Werror]
      if (recv_wqe->recv_sg_mem == NULL) {
                                ^~

    ../../common/io/ib/mgt/ibmf/ibmf_saa_utils.c: In function 'ibmf_saa_utils_pack_payload':
    ../../common/io/ib/mgt/ibmf/ibmf_saa_utils.c:977:24: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       *buf_payload_lengthp = NULL;
                            ^
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 7 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 03b18ed2fedba1f49023f25d34cbb6e4d0d8f435

commit  03b18ed2fedba1f49023f25d34cbb6e4d0d8f435
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-24T06:41:18.000Z

    10771 ibmf: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF