Actions
Bug #10777
closedpci_autoconfig: NULL pointer errors
Start date:
2019-04-14
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
Description
NULL pointer errors:
../../intel/io/pci/pci_boot.c: In function 'fix_ppb_res': ../../intel/io/pci/pci_boot.c:968:30: error: comparison between pointer and integer [-Werror] subbus + 1, range, 1) != NULL) ^~ ../../intel/io/pci/pci_boot.c: In function 'add_reg_props': ../../intel/io/pci/pci_boot.c:2603:14: error: comparison between pointer and integer [-Werror] if (base != NULL) { ^~ ../../intel/io/pci/pci_boot.c:2620:35: error: comparison between pointer and integer [-Werror] } else if ((*mem_avail && base == NULL) || ^~ ../../intel/io/pci/pci_boot.c:2629:15: error: comparison between pointer and integer [-Werror] if (base != NULL) { ^~ ../../intel/io/pci/pci_boot.c:2641:14: error: comparison between pointer and integer [-Werror] if (base == NULL) { ^~ ../../intel/io/pci/pci_boot.c:2644:15: error: comparison between pointer and integer [-Werror] if (base != NULL) { ^~ ../../intel/io/pci/pci_boot.c:2651:14: error: comparison between pointer and integer [-Werror] if (base != NULL) { ^~ ../../intel/io/pci/pci_boot.c:2703:12: error: comparison between pointer and integer [-Werror] if (base != NULL) { ^~ cc1: all warnings being treated as errors
Updated by Electric Monk about 3 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
git commit 32b17656b54efc6d9df4806aebdde39ea6f5cb4f
commit 32b17656b54efc6d9df4806aebdde39ea6f5cb4f Author: Toomas Soome <tsoome@me.com> Date: 2019-04-19T19:37:33.000Z 10777 pci_autoconfig: NULL pointer errors Reviewed by: Andy Stormont <astormont@racktopsystems.com> Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net> Approved by: Dan McDonald <danmcd@joyent.com>
Actions