Project

General

Profile

Actions

Bug #10779

closed

usba: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

NULL pointer errors:

    ../../common/io/usb/usba/hcdi.c: In function 'usba_hcdi_cb':
    ../../common/io/usb/usba/hcdi.c:566:51: error: comparison between pointer and integer [-Werror]
           hcdi_shared_cb_thread, req_wrp, TQ_NOSLEEP) ==
                                                       ^~

    ../../common/io/usb/usba/usba_devdb.c: In function 'usba_devdb_get_var_type':
    ../../common/io/usb/usba/usba_devdb.c:122:37: error: comparison between pointer and integer [-Werror]
       if (strcasecmp(cfgvar->name, str) == NULL) {
                                         ^~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit cdcfeaaebb9c28e15c04ff4d1f19261edfd9ed60

commit  cdcfeaaebb9c28e15c04ff4d1f19261edfd9ed60
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-19T19:42:42.000Z

    10779 usba: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF