Project

General

Profile

Actions

Bug #10780

closed

scsi: NULL pointer errors

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

NULL pointer errors:

../../common/io/scsi/impl/scsi_subr.c: In function 'scsi_generic_errmsg':
../../common/io/scsi/impl/scsi_subr.c:1189:15: error: comparison between pointer and integer [-Werror]
    if (buf[0] != NULL) {
               ^~

../../common/io/scsi/impl/scsi_hba.c: In function 'scsi_device_config':
../../common/io/scsi/impl/scsi_hba.c:6548:12: error: comparison between pointer and integer [-Werror]
       ((pi == NULL) && ndi_devi_device_isremoved(child))) {
            ^~
cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit e6915ea4a84088ff77aeac34866dda0a8d2cf632

commit  e6915ea4a84088ff77aeac34866dda0a8d2cf632
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-19T19:48:21.000Z

    10780 scsi: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF