Project

General

Profile

Actions
Copy link

Bug #10781

closed

arcfour: NULL pointer errors

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2019-04-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

NULL pointer errors:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/systm.h:39,
                     from ../../common/crypto/io/arcfour.c:31:
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/crypto/io/arcfour.c:144:55: note: in expansion of macro 'NULL'
     static crypto_kcf_provider_handle_t rc4_prov_handle = NULL;
                                                           ^~~~
    ../../common/crypto/io/arcfour.c: In function '_fini':
    ../../common/crypto/io/arcfour.c:171:22: error: comparison between pointer and integer [-Werror]
      if (rc4_prov_handle != NULL) {
                          ^~
    ../../common/crypto/io/arcfour.c:175:19: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       rc4_prov_handle = NULL;
                       ^
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit c4fd2a7748785a8c83d6e34d2d80dd5703690998

commit  c4fd2a7748785a8c83d6e34d2d80dd5703690998
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-19T19:53:21.000Z

    10781 arcfour: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF