Project

General

Profile

Actions
Copy link

Bug #10782

closed

blowfish: NULL pointer errors

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2019-04-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

NULL pointer errors:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/systm.h:39,
                     from ../../common/crypto/io/blowfish.c:31:
    ../../common/sys/null.h:32:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/crypto/io/blowfish.c:197:60: note: in expansion of macro 'NULL'
     static crypto_kcf_provider_handle_t blowfish_prov_handle = NULL;
                                                                ^~~~
    ../../common/crypto/io/blowfish.c: In function '_fini':
    ../../common/crypto/io/blowfish.c:221:27: error: comparison between pointer and integer [-Werror]
      if (blowfish_prov_handle != NULL) {
                               ^~
    ../../common/crypto/io/blowfish.c:225:24: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       blowfish_prov_handle = NULL;
                            ^
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit c8b1c8bdff5c74b45e33257ed7499ca0f475ebe0

commit  c8b1c8bdff5c74b45e33257ed7499ca0f475ebe0
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-19T19:55:47.000Z

    10782 blowfish: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF