Project

General

Profile

Actions
Copy link

Bug #10791

closed

dr: NULL pointer errors

Added by Toomas Soome about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2019-04-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

NULL pointer errors:

     In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/buf.h:45,
                     from ../../common/sys/devops.h:35,
                     from ../../i86pc/io/dr/dr.c:42:
    ../../i86pc/io/dr/dr.c: In function 'dr_attach':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../i86pc/io/dr/dr.c:767:48: note: in expansion of macro 'NULL'
            minor_num, DDI_NT_SBD_ATTACHMENT_POINT, NULL);
                                                    ^~~~
    In file included from ../../i86pc/io/dr/dr.c:47:0:
    ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
     ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~~~~~

Actions
Copy link
 #1

Updated by Electric Monk about 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 2002b186f847595188b1fb0b8dd800370aa6107c

commit  2002b186f847595188b1fb0b8dd800370aa6107c
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-24T07:11:00.000Z

    10791 dr: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF