Project

General

Profile

Actions
Copy link

Bug #10797

closed

npe: NULL pointer errors

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2019-04-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

NULL pointer errors:

    ../../i86pc/io/pci/pci_tools.c: In function 'pcitool_map':
    ../../i86pc/io/pci/pci_tools.c:876:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (NULL);
              ^
    ../../i86pc/io/pci/pci_tools.c:887:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (NULL);
              ^
    ../../i86pc/io/pci/pci_tools.c: In function 'pcitool_dev_reg_ops':
    ../../i86pc/io/pci/pci_tools.c:1179:18: error: comparison between pointer and integer [-Werror]
        if (virt_addr == NULL) {
                      ^~
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 49ee6bfbbe326d1f0bbc34934ab8b07a000305c4

commit  49ee6bfbbe326d1f0bbc34934ab8b07a000305c4
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-19T19:30:43.000Z

    10797 npe: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF