Project

General

Profile

Bug #10801

xencons: NULL pointer errors

Added by Toomas Soome 2 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-04-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

NULL pointer errors:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/xen/io/xencons.c:68:
    ../../common/xen/io/xencons.c: In function 'xenconsattach':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/xen/io/xencons.c:355:21: note: in expansion of macro 'NULL'
          DDI_NT_SERIAL, NULL);
                         ^~~~
    In file included from ../../common/xen/io/xencons.c:93:0:
    ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
     ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 2 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 6be20e18a2e738d2d7d3066ece3a4e71045ea88e

commit  6be20e18a2e738d2d7d3066ece3a4e71045ea88e
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-22T05:18:26.000Z

    10801 xencons: NULL pointer errors
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF