Project

General

Profile

Actions
Copy link

Bug #10812

closed

ctf tools shouldn't add blank labels

Added by John Levon over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Levon
Category:
-
Start date:
2019-04-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

SmartOS bug http://smartos.org/bugview/OS-7653

Today, when no label has been requested we end up creating a label section with an empty name. There's really no reason for such a label to exist. We should make this explicit and not have such empty labels when nothing has been passed in. If a user desired, they could still create a valid label with an empty name, though that feels of questionable utility.

Actions
Copy link
 #1

Updated by John Levon over 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk over 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 37e82d12edcc0e950e771c6cda32e45f1ecd7f8d

commit  37e82d12edcc0e950e771c6cda32e45f1ecd7f8d
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-05-03T09:15:57.000Z

    10812 ctf tools shouldn't add blank labels
    10813 ctf symbol mapping needs work
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions
Copy link

Also available in: Atom PDF