Project

General

Profile

Bug #10818

Improve ctfconvert error messages

Added by John Levon 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2019-04-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

http://smartos.org/bugview/OS-6505

By far the most common error messages from CTF converting pkgsrc is:

ctfconvert-altexec: CTF conversion failed: file does not contain valid DWARF data: Dwarf_Error is NULL

This message comes from a code path where Dwarf_Error can't be anything but NULL, so I question whether it's worth printing it, as it can be confusing for people who do not have intimate knowledge of the code.

Also note the double newline, we're currently adding one when creating the error message, as well as another one when printing it. It's only cosmetic but we should fix that too.

History

#1

Updated by Electric Monk 10 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 3eca610387779e26c8c63e26d2ba418b0cd1bf5a

commit  3eca610387779e26c8c63e26d2ba418b0cd1bf5a
Author: John Levon <john.levon@joyent.com>
Date:   2019-05-03T09:15:58.000Z

    10816 ctf_dwarf_convert_type() relies on un-initialized id
    10817 ctfconvert -i option is mis-handled
    10818 Improve ctfconvert error messages
    10819 ctfconvert should handle empty dies
    10820 ctfconvert -i never converts
    10821 bad free in ctf_dwarf_init_die
    10815 shouldn't build gcore.c as part of kmdb
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Also available in: Atom PDF